Skip to content

Commit

Permalink
fix: semverCompare call
Browse files Browse the repository at this point in the history
  • Loading branch information
wcrum committed Dec 16, 2024
1 parent 8d56197 commit 7428614
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 2 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ fileserver/
cmd/hauler/binaries
testdata/certs/
coverage.out
ebug
13 changes: 12 additions & 1 deletion cmd/hauler/cli/store/add.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,18 @@ func storeChart(ctx context.Context, s *store.Layout, chartName string, opts *fl
l.Infof("successfully added 'chart' [%s]", ref.Name())

if opts.AddImages {
values, err := chartutil.ToRenderValues(c, c.Values, chartutil.ReleaseOptions{Namespace: "hauler"}, &chartutil.Capabilities{})
if opts.HelmValues != "" {
values, err := chartutil.ReadValuesFile(opts.HelmValues)
if err != nil {
return err
}
c.Values = values
}

// mock kubeversion?
kubeversion := chartutil.KubeVersion{Version: "1", Major: "31", Minor: "0"}

values, err := chartutil.ToRenderValues(c, c.Values, chartutil.ReleaseOptions{Namespace: "hauler"}, &chartutil.Capabilities{KubeVersion: kubeversion})
if err != nil {
return err
}
Expand Down
5 changes: 4 additions & 1 deletion internal/flags/add.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ type AddChartOpts struct {

ChartOpts *action.ChartPathOptions

AddImages bool
AddImages bool
HelmValues string
}

func (o *AddChartOpts) AddFlags(cmd *cobra.Command) {
Expand All @@ -50,4 +51,6 @@ func (o *AddChartOpts) AddFlags(cmd *cobra.Command) {
f.StringVar(&o.ChartOpts.CaFile, "ca-file", "", "(Optional) Location of CA Bundle to enable certification verification")

f.BoolVar(&o.AddImages, "add-images", false, "(Optional) Add images referenced in helm template")
f.StringVarP(&o.HelmValues, "values", "f", "", "(Optional) Specify values in a YAML file or a URL (can specify multiple)")

}

0 comments on commit 7428614

Please sign in to comment.