fix cpu usage on linux #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it needs a follow up fix for the case of a re-connection is done within the thread sleep (100ms). |
wait until listening threads are closed implemented in elixir because of https://www.erlang.org/doc/apps/erts/erl_nif.html#lengthy_work
|
i changed the strategy to solve the issue by moving the midi connection close() call into the unsubscribe functions, and dropping the creation of threads. |
|
Thanks @crop2000. I'll need to study your updated solution. Looks interesting (your use of Rust is more advanced than mine!). I pushed a point release not long ago based on your previous iteration, but looking forward to studying your updated version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slow down loop in subscription thread