Dockerfile updates for traject #53
Open
+48
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove wait-for & use health checks * use production stage
aelkiss
commented
Oct 29, 2024
There was a problem hiding this comment.
should revert this change
There was a problem hiding this comment.
I wouldn't be opposed to bringing this file up to date with whatever is in the production DB and then .gitignoreing it. I've run against problems using this repo (or maybe it was hathifiles) with a stale table like this, against real-world Zephir data (bails out due to inability to find a recent institution code). It'll always be a moving target, however. Maybe worth a note in the readme.
Ronster2018
reviewed
Oct 30, 2024
moseshll
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings our dockerfile up to current standards & allows building an image we can use in kubernetes for catalog indexing