DEV-1373 make catalog indexing date independent #52
Conversation
- Add `CICTL::Journal` class for writing dated files to a predefined location to record Zephir files indexed. - Add `journal_directory` to `Services` with `ENV`-overridable default location for journal files. - Add `cictl continue` command that calls `cictl all` or `cictl since` depending on presence or absence of relevant jourmals.
…fied by Dependabot
- To availability_map_ht.rb add `orphcand`, `icus`, `supp`. - To availability_map_ht_intl.rb add the above plus `ic-world`, `und-world`, and `pd-pvt`. - Re-map `umall` to "search only" for consistency with other HT code although it is no longer used. - Re-order map entries by attribute id where possible, add comments, and where possible prefer strings over regexes. - Add tests.
…y) by changing single to double quotes.
There was a problem hiding this comment.
The journal logic all makes sense to me. The tests could perhaps be made a little bit easier to read as described in the comment.
The translation maps are a little frustrating to look at since I wish we didn't have that information duplicated in so many places... That said, if we're touching the availability maps I think it's worth considering if we can make some small improvements now -- specifically if we can remove a couple of them that may not be used, and if we can just spell out the rights codes rather than using regexes (and thereby avoid adding a test for the availability map).
There was a problem hiding this comment.
This all seems good to me. It may be worthwhile thinking at some point about how to extract some of the common functionality here and in our other ruby projects (processed file tracking, temp dirs for tests), but I don't have a clear enough sense of how to do that to suggest a specific approach right now.
CICTL::Journalclass for writing dated files to a predefined location to record Zephir files indexed.journal_directorytoServiceswithENV-overridable (ENV["JOURNAL_DIRECTORY"]) default location for such files.cictl indexcommands automatically write journals on completion.cictl continuecommand that callscictl allorcictl sincedepending on presence or absence of relevant jourmals.babelapps andhathifilesallow/deny criteria. Full suite of tests added (see the particulars in the commit message).standardrbno-go area (lib/translation_maps) by mass-changing single quotes to double (standardrb --fixchanged one or two other minor formatting issues).Requests of the Reviewer
Journalclass and its application. Fortunately the newcictl continuefunctionality mostly just builds on what is there already.availability_map_*rewrites -- is this an improvement, and is there anything to be done to improve on it?