Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#92: focus indicator bug fixes #97

Merged
merged 3 commits into from
Jul 26, 2024
Merged

#92: focus indicator bug fixes #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d91fd6
fix navbar logo link focus indicator issue
carylwyatt Jul 25, 2024
f702df7
fix active button focus indicator style
carylwyatt Jul 25, 2024
7f9497f
unset transition for focus-visible
carylwyatt Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/components/Navbar/index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
<div class="container-fluid">
<div class="ht-logo" class:compact>
<!-- <img src="../assets/HT-logo-mobile-nav.svg" alt="HathiTrust" class="" /> -->
<a href="//{HT.www_domain}/">
<a href="//{HT.www_domain}/" class="d-block">
<svg
aria-labelledby="ht-logo-title"
role="img"
Expand Down
4 changes: 3 additions & 1 deletion src/scss/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ $ht-focus-box-shadow: 0 0 0 6px #fff;
box-shadow: 0 0 0 6px #fff;
outline-offset: 4px;
z-index: 3;
transition: unset;
}

// Required
Expand Down Expand Up @@ -351,12 +352,13 @@ body[data-initialized='true'] {
}

// FOCUS STYLES
.btn, .accordion .accordion-button, select.form-select, input.form-control, textarea.form-control, input.form-check-input, :is(.was-validated) :is(.form-control, .form-select, .form-check-input) {
.btn, .btn.active, .nav-link, .accordion .accordion-button, select.form-select, input.form-control, textarea.form-control, input.form-check-input, :is(.was-validated) :is(.form-control, .form-select, .form-check-input) {
&:focus-visible {
outline: 3px solid #086AB4 !important;
outline-offset: 4px;
box-shadow: 0 0 0 6px white;
z-index: 3;
transition: unset;
}
&:focus {
outline: 3px solid transparent;
Expand Down
Loading