Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIDY ImageRemediate #145

Merged
merged 1 commit into from
Jul 29, 2024
Merged

TIDY ImageRemediate #145

merged 1 commit into from
Jul 29, 2024

Conversation

mwarin
Copy link
Contributor

@mwarin mwarin commented Jul 26, 2024

Mostly whitespace changes, so recommend viewing diff with:
https://github.com/hathitrust/feed/pull/145/files?diff=unified&w=1

The occasional other change is in the form of harmonizing the way we get input args to subs:

sub abc {
    my $self = shift;
    my ($other, $params, $like, $this) = @_;
    # ...
}

... is functionally equivalent to, perhaps more compact than, but not as good looking as:

sub abc {
    my $self   = shift;
    my $other  = shift;
    my $params = shift;
    my $like   = shift;
    my $this   = shift;
    # ...
}

... or in the way default values to arguments are done.

-    my $force_headers            = ( shift or {} );
+    my $force_headers            = shift || {};

@mwarin mwarin force-pushed the DEV-1314-tidy-imageremediate branch from 3df9cf8 to 9199186 Compare July 26, 2024 21:11
@mwarin mwarin requested a review from carylwyatt July 29, 2024 18:27
Copy link
Member

@carylwyatt carylwyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very tidy!

I had to look up shift. I learned something new today, thanks!

Approved ✅

@mwarin mwarin merged commit 21823ff into main Jul 29, 2024
1 check passed
@mwarin mwarin deleted the DEV-1314-tidy-imageremediate branch July 29, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants