Skip to content

Commit

Permalink
Fix issue with Commonwealth interface not allowing date entry for dat…
Browse files Browse the repository at this point in the history
…e type 'r' with unknown original date.

- Add "(unknown)" scenario to metadata display
- Expand logic to use "not one" instead of "equals two" as criterion for actual pub date entry.
  • Loading branch information
moseshll committed Apr 10, 2024
1 parent 2278803 commit 2be4212
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion cgi/CRMS.pm
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ sub new
return $self;
}

our $VERSION = '8.6';
our $VERSION = '8.6.1';
sub Version
{
return $VERSION;
Expand Down
6 changes: 3 additions & 3 deletions cgi/partial/ADDForm.tt
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
</td>
</tr>
<!-- ACTUAL PUB DATE -->
<!-- Only visible when pub is unchecked and pub date is a range -->
<!-- Only visible when pub is unchecked and pub date is a range or unknown -->
[% display = "table-row" %]
[% IF u_pub || data.bibdata.extracted_dates.size != 2 %]
[% IF u_pub || data.bibdata.extracted_dates.size == 1 %]
[% display = "none" %]
[% END %]
<tr id="actual-pub-date-row" style="display:[% display %];">
Expand Down Expand Up @@ -293,7 +293,7 @@ function toggleADD() {
addField.value = actualField.value;
}
} else {
if (gReviewData.bibdata.extracted_dates.length > 1) {
if (gReviewData.bibdata.extracted_dates.size != 1) {
actualPubDateRow.style.display = "table-row";
}
}
Expand Down
4 changes: 2 additions & 2 deletions cgi/partial/bibdata_commonwealth.tt
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
<tr>
<td><strong>Pub Date:</strong>
<span id="pub-date-span"
[% IF data.bibdata.extracted_dates.size > 1 %]class="red"[% END %]>
[% data.bibdata.display_date %]
[% IF data.bibdata.extracted_dates.size != 1 %]class="red"[% END %]>
[% data.bibdata.display_date || '(unknown)' %]
</span>
</td>
</tr>
Expand Down

0 comments on commit 2be4212

Please sign in to comment.