Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Dashboard Search #61

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Dynamic Dashboard Search #61

wants to merge 8 commits into from

Conversation

xyecs
Copy link
Collaborator

@xyecs xyecs commented Oct 18, 2021

What this PR does (required):

  • Allows search by location and it is dynamic

Screenshots / Videos (front-end only):

DynamicDashboard.mp4

Any information needed to test this feature (required):

  • Same steps as video

Any issues with the current functionality (optional):

  • Need to implement some other features on BE
  • Profile details IN is added on another part
  • A lot of changed files since I'm working with other merged branches that's not yet in main
  • Not sure why video is crazy bright

@xyecs xyecs self-assigned this Oct 18, 2021
This was linked to issues Oct 18, 2021
Copy link
Collaborator

@sundayezeilo sundayezeilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this one 👍 Please check out the few comments I left below so that you can address them.

client/src/components/NavBar/BecomeSitter/BecomeSitter.tsx Outdated Show resolved Hide resolved
client/src/components/NavBar/BecomeSitter/BecomeSitter.tsx Outdated Show resolved Hide resolved
client/src/components/NavBar/NavBar.tsx Outdated Show resolved Hide resolved
client/src/pages/Dashboard/Dashboard.tsx Outdated Show resolved Hide resolved
client/src/pages/ProfileDetails/ProfileDetails.tsx Outdated Show resolved Hide resolved
server/controllers/profile.js Show resolved Hide resolved
server/controllers/profile.js Outdated Show resolved Hide resolved
server/controllers/profile.js Outdated Show resolved Hide resolved
server/controllers/profile.js Outdated Show resolved Hide resolved
@@ -100,7 +100,7 @@ exports.getProfile = asyncHandler(async (req, res, next) => {
exports.getAllProfiles = asyncHandler(async (req, res, next) => {
const { search, start, end } = req.query;

if (search != "" || start != "null" || end != "null") {
if (!search || !start || !end) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FS: Dynamic dashboard FE: Profile Listings page
2 participants