Issue 22: WebRTC implementation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyunse
approved these changes
Jul 21, 2020
| @@ -1,7 +1,10 @@ | |||
| const Game = require("./models/Game"); | |||
| const { use } = require("chai"); | |||
Comment on lines
+38
to
+42
|
|
||
| sockets.on("game-started", () => { | ||
| setGame((game) => ({ ...game, isStarted: true })); | ||
| }); | ||
|
|
There was a problem hiding this comment.
These game-start parts will be modified when integrating with game-integration branch. After integrating between RTC and game, you need to check it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22
Note: NOT fully implemented yet, just added all socket and signalling handlers
If anyone could look through this PR and see what can be changed, I'd like some help with that.
Additions
RTCContext.js - provider wrapped around GameSession protected route
/server/sockets.js - added socket events for p2p signalling
Implementation is similar to https://github.com/darrenMabbayad/webrtc-simple-video-call
Utilizes simple-peer package to abstract parts of signalling process/ICE
Front End
peers- state variable which is a list of created peers to renderpeersRef- ref variable which is used to filter through socket ids and accept call signalsuserMediaRef- ref variable where the stream object is set to.current.srcObjectproperty of userMediaRefgetMediaStream()- generic async function that returns stream object under certain contraintsinitCall()- creates peer objects for the player initiating a call, signals to back end 'starting-call'answerCall()- creates peer objects for players receiving a call, signals to back end 'answering-call', accepts the initiated calluseEffectsocket event handler - handles get-player-socket-ids (which invokesinitCall()), receiving-call (which invokesanswerCall()), and accept-call-back (which looks through peersRef to accept returning offers) socket eventsBack End
starting-call - send an offer to a specific player
answering-call send an offer back to the caller