feat: support operation naming style snake_case (#144)

cmd/hasura-ndc-go/command/internal/connector.go

@@ -14,6 +14,7 @@ import (
 	"strings"
 
 	"github.com/hasura/ndc-sdk-go/schema"
+	"github.com/iancoleman/strcase"
 	"github.com/rs/zerolog/log"
 )
 
@@ -24,6 +25,7 @@ type ConnectorGenerationArguments struct {
 	PackageTypes string   `help:"The name of types package where the State struct is in"`
 	Directories  []string `help:"Folders contain NDC operation functions" short:"d"`
 	Trace        string   `help:"Enable tracing and write to target file path."`
+	Style        string   `help:"The naming style for functions and procedures. Accept: camel-case, snake-case" enum:"camel-case,snake-case" default:"camel-case"`
 }
 
 type connectorTypeBuilder struct {
@@ -500,10 +502,10 @@ func (j %s) ScalarName() string {
 				sb.imports["slices"] = ""
 
 				sb.builder.WriteString("const (\n")
-				pascalName := ToPascalCase(scalar.Name)
+				pascalName := strcase.ToCamel(scalar.Name)
 				enumConstants := make([]string, len(scalarRep.OneOf))
 				for i, enum := range scalarRep.OneOf {
-					enumConst := fmt.Sprintf("%s%s", pascalName, ToPascalCase(enum))
+					enumConst := fmt.Sprintf("%s%s", pascalName, strcase.ToCamel(enum))
 					enumConstants[i] = enumConst
 					sb.builder.WriteString(fmt.Sprintf("  %s %s = \"%s\"\n", enumConst, scalar.Name, enum))
 				}

cmd/hasura-ndc-go/command/internal/connector_test.go

@@ -31,6 +31,7 @@ func TestConnectorGeneration(t *testing.T) {
 		Directories  []string
 		ModuleName   string
 		PackageTypes string
+		NamingStyle  string
 		errorMsg     string
 	}{
 		{
@@ -75,6 +76,13 @@ func TestConnectorGeneration(t *testing.T) {
 			Directories: []string{"connector/functions"},
 			errorMsg:    "the `types` package where the State struct is in must be placed in root or connector directory",
 		},
+		{
+			Name:        "snake_case",
+			BasePath:    "./testdata/snake_case",
+			ModuleName:  "github.com/hasura/ndc-codegen-test-snake-case",
+			Directories: []string{"functions"},
+			NamingStyle: string(StyleSnakeCase),
+		},
 	}
 
 	rootDir, err := os.Getwd()
@@ -94,6 +102,7 @@ func TestConnectorGeneration(t *testing.T) {
 				ConnectorDir: tc.ConnectorDir,
 				PackageTypes: tc.PackageTypes,
 				Directories:  tc.Directories,
+				Style:        tc.NamingStyle,
 			}, tc.ModuleName)
 			if tc.errorMsg != "" {
 				assert.ErrorContains(t, err, tc.errorMsg)

cmd/hasura-ndc-go/command/internal/constant.go

@@ -7,6 +7,7 @@ import (
 	"text/template"
 
 	"github.com/hasura/ndc-sdk-go/schema"
+	"github.com/iancoleman/strcase"
 )
 
 const (
@@ -25,6 +26,11 @@ func init() {
 	if err != nil {
 		panic(fmt.Errorf("failed to parse connector template: %s", err))
 	}
+
+	strcase.ConfigureAcronym("API", "Api")
+	strcase.ConfigureAcronym("REST", "Rest")
+	strcase.ConfigureAcronym("HTTP", "Http")
+	strcase.ConfigureAcronym("SQL", "sql")
 }
 
 type ScalarName string

cmd/hasura-ndc-go/command/internal/schema.go

@@ -17,6 +17,7 @@ import (
 
 	"github.com/fatih/structtag"
 	"github.com/hasura/ndc-sdk-go/schema"
+	"github.com/iancoleman/strcase"
 	"github.com/rs/zerolog/log"
 	"golang.org/x/tools/go/packages"
 )
@@ -213,6 +214,7 @@ type SchemaParser struct {
 	rawSchema    *RawConnectorSchema
 	packages     []*packages.Package
 	packageIndex int
+	namingStyle  OperationNamingStyle
 }
 
 // GetCurrentPackage gets the current evaluating package
@@ -231,6 +233,14 @@ func (sp SchemaParser) FindPackageByPath(input string) *packages.Package {
 }
 
 func parseRawConnectorSchemaFromGoCode(ctx context.Context, moduleName string, filePath string, args *ConnectorGenerationArguments) (*RawConnectorSchema, error) {
+	var err error
+	namingStyle := StyleCamelCase
+	if args.Style != "" {
+		namingStyle, err = ParseOperationNamingStyle(args.Style)
+		if err != nil {
+			return nil, err
+		}
+	}
 	rawSchema := NewRawConnectorSchema()
 
 	pkgTypes, err := evalPackageTypesLocation(args.PackageTypes, moduleName, filePath, args.ConnectorDir)
@@ -312,6 +322,7 @@ func parseRawConnectorSchemaFromGoCode(ctx context.Context, moduleName string, f
 			packages:     packageList,
 			packageIndex: i,
 			rawSchema:    rawSchema,
+			namingStyle:  namingStyle,
 		}
 
 		err = sp.parseRawConnectorSchema(packageList[i].Types)
@@ -846,6 +857,16 @@ func (sp *SchemaParser) parseTypeInfoFromComments(typeName string, packagePath s
 	return typeInfo, nil
 }
 
+// format operation name with style
+func (sp SchemaParser) formatOperationName(name string) string {
+	switch sp.namingStyle {
+	case StyleSnakeCase:
+		return strcase.ToSnake(name)
+	default:
+		return strcase.ToLowerCamel(name)
+	}
+}
+
 func (sp *SchemaParser) parseOperationInfo(fn *types.Func) *OperationInfo {
 	functionName := fn.Name()
 	result := OperationInfo{
@@ -878,7 +899,7 @@ func (sp *SchemaParser) parseOperationInfo(fn *types.Func) *OperationInfo {
 				if matchesLen > 3 && strings.TrimSpace(matches[3]) != "" {
 					result.Name = strings.TrimSpace(matches[3])
 				} else {
-					result.Name = ToCamelCase(functionName)
+					result.Name = sp.formatOperationName(functionName)
 				}
 			} else {
 				descriptions = append(descriptions, text)
@@ -895,7 +916,7 @@ func (sp *SchemaParser) parseOperationInfo(fn *types.Func) *OperationInfo {
 			return nil
 		}
 		result.Kind = OperationKind(operationNameResults[1])
-		result.Name = ToCamelCase(operationNameResults[2])
+		result.Name = sp.formatOperationName(operationNameResults[2])
 	}
 
 	desc := strings.TrimSpace(strings.Join(descriptions, " "))