Build ndc-postgres and v3-engine binaries using Nix in e2e tests
#592
+30
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljharvey
changed the title
ndc-postgres and v3-engine binaries using Nix in e2e testsndc-postgres and v3-engine binaries using Nix in e2e tests
danieljharvey
force-pushed
the
djh/copy-e2e-testing-from-engine
branch
from
ba4f2b5
to
a50a75d
Compare
SamirTalwar
approved these changes
Aug 23, 2024
soupi
reviewed
Aug 23, 2024
Comment on lines
+65
to
+74
| env: | ||
| ENGINE_BINARY: >- | ||
| ${{ github.workspace }}/v3-engine/result/bin/engine | ||
| NDC_POSTGRES_BINARY: >- | ||
| ${{ github.workspace }}/ndc-postgres/result/bin/ndc-postgres | ||
| run: | | ||
| npm install | ||
| just start-postgres-dependencies start-apollo-subgraph | ||
| trap 'just stop-everything' EXIT | ||
| RUST_LOG=DEBUG ./crates/postgres/static/run-postgres-tests.sh '.*' "$NDC_POSTGRES_BINARY" "$ENGINE_BINARY" |
There was a problem hiding this comment.
Ah sorry, this is e2e-tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Speed up e2e tests by building the
v3-engineandndc-postgresbinaries with Nix.How
Mostly copied from the equivalent
v3-engineCI job.