Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ndc-citus #105

Merged
merged 7 commits into from
Oct 25, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/test-configuration.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
{
"ndc-citus": {
"package": "ndc-citus",
"flags": "",
"services": "citus",
"env": {
"POSTGRESQL_CONNECTION_STRING": "postgresql://postgres:password@localhost:64004"
}
},
"ndc-cockroach": {
"package": "ndc-cockroach",
"flags": "",
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/build-images-and-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
strategy:
matrix:
connector:
- ndc-citus
- ndc-cockroach
- ndc-postgres
fail-fast: false
Expand Down
38 changes: 37 additions & 1 deletion .github/workflows/cargo-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:
strategy:
matrix:
package:
- ndc-citus
- ndc-cockroach
- ndc-postgres-12
- ndc-postgres-13
Expand Down Expand Up @@ -190,3 +189,40 @@ jobs:
cargo nextest run --no-fail-fast --release -p other-db-tests --features yugabyte
env:
RUST_LOG: INFO

test-ndc-postgres-with-citus:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider matrix-ifying this please. Doesn't have to be now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry wdym?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a matrix strategy (just like the test-connector job above) instead of copying and pasting.

It's a fancy loop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I understand. Thanks.

name: test connector (ndc-postgres on Citus)
runs-on: ubuntu-latest
env:
CARGO_NET_GIT_FETCH_WITH_CLI: "true"
RUSTFLAGS: "-D warnings" # fail on warnings
steps:
- uses: actions/checkout@v4

- name: install protoc
uses: arduino/setup-protoc@v2
with:
version: "24.3"
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: install tools
run: |
rustup show
# install cargo-nextest
curl -LsSf https://get.nexte.st/latest/linux | tar zxf - -C ${CARGO_HOME:-~/.cargo}/bin

- uses: Swatinem/rust-cache@v2

- name: start dependencies
uses: isbang/[email protected]
with:
compose-file: "./docker-compose.yaml"
down-flags: "--volumes"
services: |
citus

- name: run tests
run: |
cargo nextest run --no-fail-fast --release -p other-db-tests --features citus
env:
RUST_LOG: INFO
29 changes: 6 additions & 23 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package.edition = "2021"
package.license = "Apache-2.0"

members = [
"crates/connectors/ndc-citus",
"crates/connectors/ndc-cockroach",
"crates/connectors/ndc-postgres",
"crates/query-engine/execution",
Expand Down
38 changes: 0 additions & 38 deletions crates/connectors/ndc-citus/Cargo.toml

This file was deleted.

7 changes: 0 additions & 7 deletions crates/connectors/ndc-citus/bin/main.rs

This file was deleted.

167 changes: 0 additions & 167 deletions crates/connectors/ndc-citus/src/connector.rs

This file was deleted.

3 changes: 0 additions & 3 deletions crates/connectors/ndc-citus/src/lib.rs

This file was deleted.

47 changes: 0 additions & 47 deletions crates/connectors/ndc-citus/tests/configuration_tests.rs

This file was deleted.

Loading
Loading