Skip to content

Commit

Permalink
Delete v3 and v4 configuration tests in favor of ndc-snapshot-metadat…
Browse files Browse the repository at this point in the history
…a tests (#527)

### What

The v3 and v4 configuration tests are a bit redundant because we have
the ndc-snapshot-metadata tests. This PR removes them, introduces a
snapshot for the current v4-config, and deletes the schema.json in each
dir because they are also not used in favor of `static/schema.json`.
  • Loading branch information
Gil Mizrahi authored Jul 9, 2024
1 parent 4513112 commit eb5563f
Show file tree
Hide file tree
Showing 16 changed files with 4,073 additions and 10,171 deletions.
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/configuration/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,4 @@ tokio = { workspace = true, features = ["full"] }
tracing = { workspace = true }

[dev-dependencies]
insta = { workspace = true, features = ["json"] }
jsonschema = { workspace = true }
3 changes: 0 additions & 3 deletions crates/configuration/src/version3/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ use crate::error::{
use crate::values::{ConnectionUri, Secret};
use crate::VersionTag;

#[cfg(test)]
mod tests;

const CONFIGURATION_FILENAME: &str = "configuration.json";
const CONFIGURATION_JSONSCHEMA_FILENAME: &str = "schema.json";
const CONFIGURATION_QUERY: &str = include_str!("version3.sql");
Expand Down
Loading

0 comments on commit eb5563f

Please sign in to comment.