remove ndc-citus (#105)

### What

Since ndc-citus is essentially exactly like ndc-postgres, and we don't
see that changing in the near future, we'd like to remove the ndc-citus
binary but keep testing against citus.

### How

- Copy yugabyte setup in `other-db-tests` for citus 
- import the other tests from `ndc-citus`
- get rid of ndc-citus
- fix references

.github/test-configuration.json

@@ -1,12 +1,4 @@
 {
-  "ndc-citus": {
-    "package": "ndc-citus",
-    "flags": "",
-    "services": "citus",
-    "env": {
-      "POSTGRESQL_CONNECTION_STRING": "postgresql://postgres:password@localhost:64004"
-    }
-  },
   "ndc-cockroach": {
     "package": "ndc-cockroach",
     "flags": "",

.github/workflows/build-images-and-deploy.yaml

@@ -14,7 +14,6 @@ jobs:
     strategy:
       matrix:
         connector:
-          - ndc-citus
           - ndc-cockroach
           - ndc-postgres
       fail-fast: false

.github/workflows/cargo-test.yaml

@@ -38,7 +38,6 @@ jobs:
     strategy:
       matrix:
         package:
-          - ndc-citus
           - ndc-cockroach
           - ndc-postgres-12
           - ndc-postgres-13
@@ -155,7 +154,12 @@ jobs:
           SLACK_WEBHOOK_URL: ${{ secrets.BROKEN_BUILD_SLACK_WEBHOOK_URL }}
 
   test-ndc-postgres-with-yugabyte:
-    name: test connector (ndc-postgres on Yugabyte)
+    strategy:
+      matrix:
+        database:
+          - yugabyte
+          - citus
+    name: "test connector (ndc-postgres on ${{ matrix.database }})"
     runs-on: ubuntu-latest
     env:
       CARGO_NET_GIT_FETCH_WITH_CLI: "true"
@@ -183,10 +187,10 @@ jobs:
           compose-file: "./docker-compose.yaml"
           down-flags: "--volumes"
           services: |
-            yugabyte
+            ${{ matrix.database }}
 
       - name: run tests
         run: |
-          cargo nextest run --no-fail-fast --release -p other-db-tests --features yugabyte
+          cargo nextest run --no-fail-fast --release -p other-db-tests --features ${{ matrix.database }}
         env:
           RUST_LOG: INFO

Cargo.toml

@@ -6,7 +6,6 @@ package.edition = "2021"
 package.license = "Apache-2.0"
 
 members = [
-  "crates/connectors/ndc-citus",
   "crates/connectors/ndc-cockroach",
   "crates/connectors/ndc-postgres",
   "crates/query-engine/execution",