Skip to content

Commit

Permalink
update READMEs of sql server and databricks about the aggregates …
Browse files Browse the repository at this point in the history 
…bug (#418)

Co-authored-by: gneeri <[email protected]>
  • Loading branch information
@codingkarthik @gneeri
codingkarthik and gneeri authored Dec 30, 2024
1 parent 1c51f50 commit bd3a1c0
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 40 deletions.
38 changes: 19 additions & 19 deletions registry/hasura/databricks/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,25 +19,25 @@ This connector implements the [Data Connector Spec](https://github.com/hasura/nd

Below, you'll find a matrix of all supported features for the Databricks connector:

| Feature | Supported | Notes |
|---------------------------------|-----------|-------|
| Native Queries + Logical Models | ❌ | |
| Native Mutations | ❌ | |
| Simple Object Query | ✅ | |
| Filter / Search | ✅ | |
| Simple Aggregation | ✅ | |
| Sort | ✅ | |
| Paginate | ✅ | |
| Table Relationships | ❌ | |
| Views | ✅ | |
| Remote Relationships | ✅ | |
| Custom Fields | ❌ | |
| Mutations | ❌ | |
| Distinct | ❌ | |
| Enums | ❌ | |
| Naming Conventions | ❌ | |
| Default Values | ❌ | |
| User-defined Functions | ❌ | |
| Feature | Supported | Notes |
|---------------------------------|-----------|-------------------------------------------------------------------------------------------------------------------------|
| Native Queries + Logical Models | ❌ | |
| Native Mutations | ❌ | |
| Simple Object Query | ✅ | |
| Filter / Search | ✅ | |
| Simple Aggregation | ✅ | There is a known issue with the `limit` feature when used with aggregate functions where the `limit` argument is ignored. |
| Sort | ✅ | |
| Paginate | ✅ | |
| Table Relationships | ❌ | |
| Views | ✅ | |
| Remote Relationships | ✅ | |
| Custom Fields | ❌ | |
| Mutations | ❌ | |
| Distinct | ❌ | |
| Enums | ❌ | |
| Naming Conventions | ❌ | |
| Default Values | ❌ | |
| User-defined Functions | ❌ | |

## Prerequisites

Expand Down
42 changes: 21 additions & 21 deletions registry/hasura/sqlserver/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[![ndc-hub](https://img.shields.io/badge/ndc--hub-sqlserver-blue.svg?style=flat)](https://hasura.io/connectors/sqlserver)
[![License](https://img.shields.io/badge/license-Apache--2.0-purple.svg?style=flat)](LICENSE.txt)

> **Note:** ADO.NET is the supported connection string format for SQL Server for ndc-sqlserver in DDN.
> **Note:** ADO.NET is the supported connection string format for SQL Server for ndc-sqlserver in DDN.
> You can find the documentation for ADO.NET SQL Server connection strings [here](https://learn.microsoft.com/en-us/dotnet/framework/data/adonet/connection-string-syntax#sqlclient-connection-strings).
> This is a change from Hasura version 2, where ODBC connection strings were supported.
Expand All @@ -24,26 +24,26 @@ the [Data Connector Spec](https://github.com/hasura/ndc-spec).

Below, you'll find a matrix of all supported features for the SQL Server connector:

| Feature | Supported | Notes |
| ------------------------------- | --------- | ------------------------------------ |
| Native Queries + Logical Models | ✅ | |
| Native Mutations | ✅ | |
| Simple Object Query | ✅ | |
| Filter / Search | ✅ | |
| Simple Aggregation | ✅ | |
| Sort | ✅ | |
| Paginate | ✅ | |
| Table Relationships | ✅ | |
| Views | ✅ | |
| Remote Relationships | ✅ | |
| Stored Procedures | ✅ | |
| Custom Fields | ❌ | |
| Mutations | ❌ | Only native mutations are suppported |
| Distinct | ✅ | |
| Enums | ❌ | |
| Naming Conventions | ❌ | |
| Default Values | ❌ | |
| User-defined Functions | ❌ | |
| Feature | Supported | Notes |
|---------------------------------|-----------|----------------------------------------------------------------------------------------------------------------------------------------------------------|
| Native Queries + Logical Models | ✅ | |
| Native Mutations | ✅ | |
| Simple Object Query | ✅ | |
| Filter / Search | ✅ | |
| Simple Aggregation | ✅ | The limit parameter does not work as expected when combined with aggregate functions. Currently, any limit value set in these cases will be disregarded. |
| Sort | ✅ | |
| Paginate | ✅ | |
| Table Relationships | ✅ | |
| Views | ✅ | |
| Remote Relationships | ✅ | |
| Stored Procedures | ✅ | |
| Custom Fields | ❌ | |
| Mutations | ❌ | Only native mutations are suppported |
| Distinct | ✅ | |
| Enums | ❌ | |
| Naming Conventions | ❌ | |
| Default Values | ❌ | |
| User-defined Functions | ❌ | |

## Prerequisites

Expand Down

0 comments on commit bd3a1c0

Please sign in to comment.