Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: make use of NIPs easier #32

Merged
merged 3 commits into from
Mar 18, 2024
Merged

refactor!: make use of NIPs easier #32

merged 3 commits into from
Mar 18, 2024

Conversation

hasundue
Copy link
Owner

  • refactor: move std/streams.ts to lib/
  • build: create lib and std modules

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 77.14286% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 83.35%. Comparing base (b887f8e) to head (70d907e).

❗ Current head 70d907e differs from pull request most recent head 9839388. Consider uploading reports for the commit 9839388 to get more accurate results

Files Patch % Lines
std/signs.ts 48.78% 21 Missing ⚠️
nips/nodes.ts 67.56% 12 Missing ⚠️
core/relays.ts 91.66% 3 Missing ⚠️
nips/01/relays.ts 57.14% 3 Missing ⚠️
lib/streams.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   86.73%   83.35%   -3.38%     
==========================================
  Files          17       20       +3     
  Lines         618      679      +61     
  Branches       43       41       -2     
==========================================
+ Hits          536      566      +30     
- Misses         80      111      +31     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hasundue hasundue force-pushed the easy-nips branch 11 times, most recently from 6f0ffe4 to 70d907e Compare March 18, 2024 13:27
WIP: refactor: nip module

refactor: thin core
@hasundue hasundue marked this pull request as ready for review March 18, 2024 13:38
@hasundue hasundue merged commit 23c7344 into main Mar 18, 2024
4 checks passed
@hasundue hasundue deleted the easy-nips branch March 18, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant