Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: abandon core/nips.ts #30

Merged
merged 4 commits into from
Feb 27, 2024
Merged

refactor(core)!: abandon core/nips.ts #30

merged 4 commits into from
Feb 27, 2024

Conversation

hasundue
Copy link
Owner

BREAKING CHANGE: Abandon nips query parameter for imported modules.

Also remove an unused logger field in NostrNodeOption.

BREAKING CHANGE: Abandon `nips` query parameter for imported modules.

Also remove an unused `logger` field in `NostrNodeOption`.
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 91.83673% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.04%. Comparing base (3ee3d45) to head (06b3912).

Files Patch % Lines
nips/01/relays.ts 78.57% 3 Missing ⚠️
core/nodes.ts 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   86.52%   87.04%   +0.52%     
==========================================
  Files          19       18       -1     
  Lines         705      633      -72     
  Branches       49       44       -5     
==========================================
- Hits          610      551      -59     
+ Misses         93       80      -13     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hasundue hasundue marked this pull request as ready for review February 27, 2024 04:49
@hasundue hasundue merged commit 74812dd into main Feb 27, 2024
6 checks passed
@hasundue hasundue deleted the abandon-core-nips branch February 27, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant