Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify modular architecture #27

Merged
merged 16 commits into from
Feb 15, 2024
Merged

refactor: simplify modular architecture #27

merged 16 commits into from
Feb 15, 2024

Conversation

hasundue
Copy link
Owner

  • simplify nodes.ts
  • nodes: make aborter hard-private
  • further simplification of nodes
  • relays: migrating to new APIs
  • refactoring relays
  • refactor nip01 relays
  • simplification
  • wip
  • update core/clients.ts
  • implement addModule in nodes
  • core modules to pass checks
  • fix nodes for nip01 relays to pass tests
  • fix NostrNodeModule to pass Relay or Client
  • update nip01 clients to pass test
  • fix core/relays for lib/relays to pass test
  • update nip42 relays to pass test

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (2e63a5a) 87.09% compared to head (5897e1b) 85.22%.

Files Patch % Lines
nips/01/relays.ts 71.42% 12 Missing ⚠️
nips/01/clients.ts 73.33% 8 Missing ⚠️
core/nodes.ts 80.00% 5 Missing ⚠️
core/relays.ts 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   87.09%   85.22%   -1.87%     
==========================================
  Files          19       19              
  Lines         744      677      -67     
  Branches       49       43       -6     
==========================================
- Hits          648      577      -71     
- Misses         95       99       +4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hasundue hasundue changed the title refactor refactor: simplify modular architecture Feb 15, 2024
@hasundue hasundue merged commit 45c93ed into main Feb 15, 2024
4 of 6 checks passed
@hasundue hasundue deleted the refactor branch February 15, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant