Update Nginx Proxy Manager to v2.12.1 #612
Conversation
WalkthroughThis pull request introduces updates to the Nginx Proxy Manager, focusing on version upgrades, configuration path changes, and dependency modifications. The changes include updating the base Docker image, Nginx Proxy Manager version, and various package versions. A significant modification is the migration of data and configuration paths from Changes
Sequence DiagramsequenceDiagram
participant Docker as Docker Build
participant Base as Base Image
participant NPM as Nginx Proxy Manager
participant Config as Configuration
Docker->>Base: Use updated base-nodejs:0.2.5
Base->>NPM: Install NPM v2.12.1
NPM->>Config: Migrate paths from /data/ to /config/
Config->>Docker: Redirect logs to stdout
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
proxy-manager/patches/0003-Patch-npm-certbot-venv-plugin-handling.patch (1)
20-22: Consider enhancing error handlingThe command execution and logging look good, but consider adding specific error messages for common pip installation failures.
return utils.exec(cmd) .then((result) => { logger.complete(`Installed ${pluginKey}`); + }) + .catch((error) => { + logger.error(`Failed to install ${pluginKey}: ${error.message}`); + throw error; });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
proxy-manager/Dockerfile(3 hunks)proxy-manager/patches/0001-patch-data-to-config-folder.patch(18 hunks)proxy-manager/patches/0002-Patch-redirect-logs-to-docker-output.patch(5 hunks)proxy-manager/patches/0002-patch-sass-version-in-frontend.patch(0 hunks)proxy-manager/patches/0003-Patch-npm-certbot-venv-plugin-handling.patch(1 hunks)proxy-manager/patches/0004-patch-certbot-venv-plugin-handling.patch(0 hunks)proxy-manager/requirements.txt(1 hunks)
💤 Files with no reviewable changes (2)
- proxy-manager/patches/0002-patch-sass-version-in-frontend.patch
- proxy-manager/patches/0004-patch-certbot-venv-plugin-handling.patch
✅ Files skipped from review due to trivial changes (1)
- proxy-manager/requirements.txt
🔇 Additional comments (6)
proxy-manager/patches/0003-Patch-npm-certbot-venv-plugin-handling.patch (2)
15-16: LGTM: Version replacement handling
The version replacement logic for plugin dependencies and versions is maintained correctly.
18-19: Review virtual environment handling changes
The removal of virtual environment activation/deactivation and cache control flags raises several concerns:
- Without virtual environment activation, packages might install system-wide instead of in the isolated certbot environment
- Removing
--no-cache-dircould affect build reproducibility
Let's verify the virtual environment setup and package installation location:
proxy-manager/Dockerfile (2)
1-1: LGTM: Version updates look good
The updates to the base image (0.2.2 → 0.2.5) and Nginx Proxy Manager (2.10.4 → 2.12.1) are minor version increments, suggesting backward compatibility is maintained.
Also applies to: 16-16
19-21: LGTM: Security-related package updates
Good security practices observed:
- Addition of explicit libcrypto3 and libssl3 dependencies
- Updates to OpenSSL and Python packages to latest patch versions
Also applies to: 26-26, 28-28, 37-37, 39-39
proxy-manager/patches/0002-Patch-redirect-logs-to-docker-output.patch (1)
Line range hint 1-140: LGTM: Excellent logging practice for containerized applications
The patch correctly redirects all Nginx logs to Docker's standard output (/proc/1/fd/1), which:
- Follows container best practices
- Enables centralized log collection
- Simplifies log management in orchestrated environments
proxy-manager/patches/0001-patch-data-to-config-folder.patch (1)
Line range hint 1-427: Path migration implementation looks good, but verify migration strategy
The patch consistently updates all paths from /data to /config, affecting:
- Configuration files
- SSL certificates
- Database location
- Access lists
- Log files
While the implementation is thorough, this change could impact existing installations.
Let's check if there's a migration strategy in place:
Chained PR on top of #611
Updating the patches was quite a pain 😞
Summary by CodeRabbit
New Features
Bug Fixes
/datato/configacross various components.Documentation
Chores