Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Data.Text.show and Data.Text.Lazy.show #608

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

Lysxia
Copy link
Contributor

@Lysxia Lysxia commented Aug 8, 2024

Closes #183

@Bodigrim Bodigrim merged commit 6ed3cae into haskell:master Aug 8, 2024
24 of 25 checks passed
@Bodigrim
Copy link
Contributor

Bodigrim commented Aug 8, 2024

Awesome!

@andreasabel
Copy link
Member

andreasabel commented Jan 2, 2025

Maybe this should have been in 2.2 rather 2.1.2.
Formally it is ok with PVP to add a new function in a minor bump.
However, since show is in Prelude, everyone importing Data.Text unqualified will get breakage.
So maybe 2.2 would have been wiser...

@Bodigrim
Copy link
Contributor

Bodigrim commented Jan 2, 2025

It's abundantly obvious that importing Data.Text unqualified is unwise, because there dozens of clashes with Prelude, be it with show or without it.

Even in a hindsight, making it 2.2 would not save us any work: since http-link-header has no upper bounds at all, you'd still have to revise it... plus hundreds of innocent packages with text < 2.2 atop of it.

@andreasabel
Copy link
Member

Yeah, I guess that's right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tshow function
3 participants