Data.Text.IO.Utf8: use B.putStrLn instead of B.putStr t >> B.putStr "\n" #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not just a stylistic change: it also improves atomicity of putStrLn in concurrent environment, when multiple threads attempt to execute it at once. See https://www.snoyman.com/blog/2016/11/haskells-missing-concurrency-basics/ (Now B.putStrLn is not perfect either, but that's the problem to solve in bytestring)
Lysxia
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not just a stylistic change: it also improves atomicity of
putStrLnin concurrent environment, when multiple threads attempt to execute it at once. See https://www.snoyman.com/blog/2016/11/haskells-missing-concurrency-basics/(Now
B.putStrLnis not perfect either, but that's the problem to solve inbytestring)