Remove hie-compat
#4613
Open
Remove hie-compat
#4613
+111
−2,514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschrempf
force-pushed
the
dom/remove-hie-compat
branch
4 times, most recently
from
d330291 to
3c9d053
Compare
dschrempf
requested review from
michaelpj,
0rphee,
soulomoon,
santiweight,
eddiemundo,
ozkutuk,
kokobd,
July541,
wz1000 and
fendor
as code owners
|
Yeah, I think this is a good idea. In principle, I think we'd like to have some kind of compatibility layer library, but in practice I think it's just spread out everywhere. |
|
There is |
dschrempf
force-pushed
the
dom/remove-hie-compat
branch
2 times, most recently
from
b6b5ecb to
ec910c4
Compare
|
Any other opinions? (I don't feel like dragging this along for too long, but maybe there is a way forward?) |
|
I think @wz1000 is most likely to have a real opinion? |
dschrempf
force-pushed
the
dom/remove-hie-compat
branch
3 times, most recently
from
9d3f4d8 to
11ab93f
Compare
While removing references to GHC 9.4, I realized that some parts of HLS are referring to even older versions of GHC. For example, `hie-compat` is a compatibility library backporting support of Haskell IDE Engine (HIE) features to older versions of GHC. Since GHC 9.2, `hie-compat` only re-exported definitions already present in the `ghc` library, and so, is essentially obsolete. FYI: We still have `hie-compat` in the dependency graph, because some libraries (e.g., `hiedb`) are using it.
dschrempf
force-pushed
the
dom/remove-hie-compat
branch
from
11ab93f to
be8be55
Compare
|
It seems there are no more opinions. I sgguest reviewing/merging or closing this PR. |
|
I think we just need an opinion from @wz1000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing support for GHC 9.4, I was in the mood of cleaning up a bit more. While removing references to GHC 9.4, I realized that some parts of HLS are referring to even older versions of GHC.
Now, some people may hate me for that, but: I completely removed the now obsolete
hie-compatlibrary.hie-compatis a compatibility library backporting support of Haskell IDE Engine (HIE) features to older versions of GHC. Since GHC 9.2,hie-compatonly re-exported definitions already present in theghclibrary, and so, is essentially obsolete.FYI: We still have
hie-compatin the dependency graph, because some libraries (e.g.,hiedb) are using it.This may be a bit harsh, but let me know what you think!