gracefully handle errors for unsupported cabal version #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridewald
commented
Oct 12, 2024
fridewald
force-pushed
the
4401/gracfully_handle_errors_for_unsupported_cable_version
branch
from
c8db13a
to
1116c31
Compare
fendor
changed the title
fridewald
changed the title
Signed-off-by: Julian Kalema Lukwata <[email protected]>
fridewald
force-pushed
the
4401/gracfully_handle_errors_for_unsupported_cable_version
branch
from
1116c31
to
9460d61
Compare
fridewald
force-pushed
the
4401/gracfully_handle_errors_for_unsupported_cable_version
branch
from
295dcb8
to
40173f4
Compare
fendor
changed the title
fendor
approved these changes
Oct 15, 2024
| @@ -252,12 +252,13 @@ cabalRules recorder plId = do | |||
| -- We don't support the cabal version, this should not be an error, as the | |||
| -- user did not do anything wrong. Instead we cast it to a warning | |||
| regex = "Unsupported cabal-version [0-9]+.[0-9]*" | |||
| unsupportedCabalHelpText = "\nThe used cabal version is not fully supported by hls. This means that some functionallity might not work as expected.\nIf you face any issues try to downgrade to a supported cabal version." | |||
There was a problem hiding this comment.
We can get the set of supported versions from https://github.com/haskell/haskell-language-server/blob/master/plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Data.hs#L33 and display it here for the best UX.
You can pull out the lower bound into its own dedicated variable, e.g.
lowestSupportedCabalVersion = CabalSpecV2_2and then use that. Or pull out the list of supported cabal versions... Either way is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that line number 0 returned from cabal is handled correctly.
This caused the marking of the whole cabal file if the cabal version is not supported as described in #4401