Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack deps update cabal-add dependency #4388

Closed
wants to merge 67 commits into from
Closed

Stack deps update cabal-add dependency #4388

wants to merge 67 commits into from

Conversation

VenInf
Copy link
Contributor

@VenInf VenInf commented Aug 21, 2024

The temporary dependency solution should be changed since cabal-add was released on Haskage.

VenInf and others added 30 commits August 18, 2024 22:34
@VenInf
cabal-add code action traces
4004210
@VenInf
showing specific code action
76af0ab
@VenInf
hidden package progress
b2e45a0
@VenInf
+ hidden-package test case
a940b58
@VenInf
test cases update
ccbd228
@VenInf
embedded cabal-add
0266514
@VenInf
cabal-add CodeAction, PATH cabal-add install
5cf86c8
@VenInf
+ cabal file path in CodeAction
fc2db8f
@VenInf
WIP command arguments
922cfe5
@VenInf
WIP hardcoded cabal-add
e20da0d
@VenInf
+ cabal-add
a032bc0
@VenInf
catched parameters in a command
9c64de8
@VenInf
working prototype
f633e70
@VenInf
adds package's version if detected
fd719e6
@VenInf
+ docs
2087b06
@VenInf
+ source-repository-package cabal-add
980e4ed
@VenInf
parsing comma
01e33c8
@VenInf
+ build targets
c8cde85
@VenInf
WIP resolve multiple targets
707316b
@VenInf
resolve target, no multiple
5f1694b
@VenInf
rule usage, refactoring
419a48a
@VenInf
better findResponsibleCabalFile
3977151
@VenInf
runAction data lookup
1ad4356
@VenInf
bugfix
68b9a64
@VenInf
WIP tests
f729147
@VenInf
WIP tests, ghcIdePlugin issue(?)
d06fa2e
@fendor @VenInf
WIP: make tests fail for good reason
fca76cb
@VenInf
WIP tests, succesfull CodeAction call
260d333
@VenInf
WIP from writeFile to edit
7258ea0
@VenInf
WIP logging prototype
497b1fc
VenInf and others added 27 commits August 18, 2024 22:39
@VenInf
test dashed change
5157063
@VenInf
regex tests
0b335fd
@VenInf
formatting
7704af3
@VenInf @VeryMilkyJoe
Update plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd.hs
a661b3b 
Co-authored-by: VeryMilkyJoe <[email protected]>
@VenInf
tests, formatting, other
11a7496
@VenInf
formatting
37522fa
@VenInf
descriptor
1ae3613
@VenInf @fendor
Apply suggestions from code review
f1ef7c9 
small review changes

Co-authored-by: fendor <[email protected]>
@VenInf
diagnostic optimisation
911ccbe
@VenInf @fendor
Update plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd.hs
d9bf2b2 
Co-authored-by: fendor <[email protected]>
@VenInf @fendor
Apply suggestions from code review
831b110 
Co-authored-by: fendor <[email protected]>
@VenInf
HlsPlugins rename id
9cb82b8
@VenInf
docs, revert changes
7b36ae2
@VenInf
logs, docs
cca5bfc
@VenInf
more docs
5fb7943
@VenInf
docs
a3ea3b0
@VenInf
imports
78913d3
@VenInf
docs
f2129d4
@VenInf
schema
0b26f5d
@VenInf @fendor
Apply suggestions from code review
e4e363b 
Co-authored-by: fendor <[email protected]>
@VenInf
- logs and empty suggestion
76f064c
@VenInf
- empty recorder
310226f
@VenInf
docs
ae6a060
@VenInf
resolve merging issues
385d83b
@fendor
Merge branch 'master' into cabal-add-codeaction
68deb73
@fendor
Add cabal-add extra-dep for stack files
e8c6051
@VenInf
cabal-add release
5dad02a
@VenInf VenInf closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj Awaiting requested review from michaelpj michaelpj is a code owner

@fendor fendor Awaiting requested review from fendor fendor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VenInf @fendor