Fix main-is completion suggestions not being relative to hs-source-dirs
#3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeryMilkyJoe
force-pushed
the
fp-completion-fix
branch
3 times, most recently
from
27ee748
to
379d385
Compare
fendor
requested changes
Aug 21, 2023
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Completer/Paths.hs
Outdated
Show resolved
Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Completer/Paths.hs
Outdated
Show resolved
Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Data.hs
Outdated
Show resolved
Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Data.hs
Outdated
Show resolved
Hide resolved
VeryMilkyJoe
force-pushed
the
fp-completion-fix
branch
2 times, most recently
from
dd8aba8
to
3820877
Compare
VeryMilkyJoe
force-pushed
the
fp-completion-fix
branch
from
3820877
to
1fe889d
Compare
|
@VeryMilkyJoe Is it possible to replace |
|
@July541 I think that's possible, can you create an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3765.
Completion suggestions for the
main-isfield are now relative to the correspondinghs-source-dirsfield.Also added a test which ensures this.