Simplify the specification of the testing job #3492
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
force-pushed
the
mpj/test-job-matrix
branch
from
aea1f8f to
88d8ef7
Compare
michaelpj
force-pushed
the
mpj/test-job-matrix
branch
5 times, most recently
from
f066b2e to
914f77d
Compare
michaelpj
commented
Jun 11, 2023
| @@ -57,11 +57,9 @@ runs: | |||
| - if: inputs.shorten-hls == 'true' | |||
| name: Workaround shorten binary names | |||
| run: | | |||
| sed -i.bak -e 's/haskell-language-server/hls/g' \ | |||
| -e 's/haskell_language_server/hls/g' \ | |||
| sed -i.bak -e 's/executable haskell-language-server/executable hls/g' \ | |||
There was a problem hiding this comment.
This now just shortens the executable names, not the package name. That makes it easier to refer to the package.
This moves the specificaiton of which packages we have and which versions of GHC they don't support to a data file, which we can then use to select the packages to build programmatically, rather than having an explicit listing of steps in the workflow file.
michaelpj
force-pushed
the
mpj/test-job-matrix
branch
from
4fef983 to
2b22b2a
Compare
michaelpj
changed the title
|
I think we should do the same thing in |
michaelpj
force-pushed
the
mpj/test-job-matrix
branch
from
60deeac to
883fd4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't make the matrix thing work, but this still makes it so that we can programmatically select the packages to build.