Skip to content

Refactor Workerqueue, add waiting empty utility for testing #6336

Refactor Workerqueue, add waiting empty utility for testing

Refactor Workerqueue, add waiting empty utility for testing #6336

Triggered via pull request June 25, 2024 14:17
Status Success
Total duration 47s
Artifacts

hlint.yml

on: pull_request
Hlint check run
39s
Hlint check run
Fit to window
Zoom out
Zoom in

Annotations

15 warnings
Hlint check run
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Hlint check run
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Hlint check run: exe/Wrapper.hs#L1
Warning in module Main: Use module export list ▫︎ Found: "module Main where" ▫︎ Perhaps: "module Main (\n module Main\n ) where" ▫︎ Note: an explicit list is usually better
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L645
Warning in loadSessionWithOptions in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef' cradle_files (\\ xs -> (cfp : xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ cradle_files ((:) cfp)"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L835
Suggestion in checkHomeUnitsClosed' in module Development.IDE.Session: Redundant $ ▫︎ Found: "OS.fromList $ this_deps" ▫︎ Perhaps: "OS.fromList this_deps"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L893
Suggestion in newComponentCache in module Development.IDE.Session: Redundant bracket ▫︎ Found: "(homeUnitId_ (componentDynFlags ci)) `OS.member` bad_units" ▫︎ Perhaps: "homeUnitId_ (componentDynFlags ci) `OS.member` bad_units"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L1157
Suggestion in setOptions in module Development.IDE.Session: Redundant $ ▫︎ Found: "map B.pack $ this_opts" ▫︎ Perhaps: "map B.pack this_opts"
Hlint check run: ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L1
Warning in module Development.IDE.Session.Diagnostics: Use module export list ▫︎ Found: "module Development.IDE.Session.Diagnostics where" ▫︎ Perhaps: "module Development.IDE.Session.Diagnostics (\n module Development.IDE.Session.Diagnostics\n ) where" ▫︎ Note: an explicit list is usually better
Hlint check run: ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L87
Warning in parseMultiCradleErr in module Development.IDE.Session.Diagnostics: Use drop1 ▫︎ Found: "drop 1" ▫︎ Perhaps: "drop1"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L71
Warning in module Development.IDE.Core.Compile: Use fewer imports ▫︎ Found: "import Development.IDE.Core.FileStore ( resetInterfaceStore )\nimport Development.IDE.Core.FileStore ( shareFilePath )\n" ▫︎ Perhaps: "import Development.IDE.Core.FileStore\n ( resetInterfaceStore, shareFilePath )\n"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L296
Suggestion in captureSplicesAndDeps in module Development.IDE.Core.Compile: Redundant bracket ▫︎ Found: "((expectJust \"hscCompileCoreExpr'\"\n $ lookup (idName binding_id) fv_hvs), \n lbss, pkgs)" ▫︎ Perhaps: "(expectJust \"hscCompileCoreExpr'\"\n $ lookup (idName binding_id) fv_hvs, \n lbss, pkgs)"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L957
Suggestion in getModSummaryFromImports in module Development.IDE.Core.Compile: Redundant bracket ▫︎ Found: "((ideclPkgQual i), reLoc $ ideclName i)" ▫︎ Perhaps: "(ideclPkgQual i, reLoc $ ideclName i)"
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/