Better plugin error infrastructure #3988
Annotations
14 warnings
Hlint check run
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Hlint check run:
exe/Wrapper.hs#L1
Warning in module Main: Use module export list ▫︎ Found: "module Main where" ▫︎ Perhaps: "module Main (\n module Main\n ) where" ▫︎ Note: an explicit list is usually better
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L618
Warning in loadSessionWithOptions in module Development.IDE.Session: Use map ▫︎ Found: "zip (map fst $ concatMap toFlagsMap all_targets) (repeat hieYaml)" ▫︎ Perhaps: "map (, hieYaml) (map fst $ concatMap toFlagsMap all_targets)" ▫︎ Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L824
Suggestion in newComponentCache in module Development.IDE.Session: Use let ▫︎ Found: "hscEnv' <- pure\n $ hscSetFlags\n df hsc_env {hsc_IC = (hsc_IC hsc_env) {ic_dflags = df}}" ▫︎ Perhaps: "let hscEnv'\n = hscSetFlags\n df hsc_env {hsc_IC = (hsc_IC hsc_env) {ic_dflags = df}}"
|
Hlint check run:
ghcide/src/Development/IDE/Main.hs#L1
Warning in module Development.IDE.Main: Unused LANGUAGE pragma ▫︎ Found: "{-# LANGUAGE PackageImports #-}"
|
Hlint check run:
ghcide/src/Development/IDE/Core/Compile.hs#L180
Suggestion in TypecheckHelpers in module Development.IDE.Core.Compile: Redundant bracket ▫︎ Found: "getLinkables :: ([NormalizedFilePath] -> IO [LinkableResult])" ▫︎ Perhaps: "getLinkables :: [NormalizedFilePath] -> IO [LinkableResult]"
|
Hlint check run:
ghcide/src/Development/IDE/Core/Compile.hs#L298
Suggestion in captureSplicesAndDeps in module Development.IDE.Core.Compile: Move guards forward ▫︎ Found: "[moduleName mod |\n n <- uniqDSetToList (bcoFreeNames bcos),\n Just mod <- [nameModule_maybe n],\n not (isWiredInName n),\n moduleUnitId mod `elem` home_unit_ids]" ▫︎ Perhaps: "[moduleName mod |\n n <- uniqDSetToList (bcoFreeNames bcos),\n not (isWiredInName n),\n Just mod <- [nameModule_maybe n],\n moduleUnitId mod `elem` home_unit_ids]"
|
Hlint check run:
ghcide/src/Development/IDE/Core/Compile.hs#L596
Suggestion in mkHiFileResultCompile in module Development.IDE.Core.Compile: Redundant $ ▫︎ Found: "(map flattenBinds . (: [])) $ prepd_binds" ▫︎ Perhaps: "(map flattenBinds . (: [])) prepd_binds"
|
Hlint check run:
ghcide/src/Development/IDE/Core/Compile.hs#L597
Suggestion in mkHiFileResultCompile in module Development.IDE.Core.Compile: Redundant $ ▫︎ Found: "(map flattenBinds . (: [])) $ prepd_binds'" ▫︎ Perhaps: "(map flattenBinds . (: [])) prepd_binds'"
|
Hlint check run:
ghcide/src/Development/IDE/Core/Compile.hs#L613
Suggestion in mkHiFileResultCompile in module Development.IDE.Core.Compile: Redundant bracket ▫︎ Found: "if isOtherUnfolding (realIdUnfolding v) then\n (setIdUnfolding v noUnfolding)\nelse\n v" ▫︎ Perhaps: "if isOtherUnfolding (realIdUnfolding v) then\n setIdUnfolding v noUnfolding\nelse\n v"
|
Hlint check run:
ghcide/src/Development/IDE/Core/Compile.hs#L1704
Suggestion in getDocsBatch in module Development.IDE.Core.Compile: Redundant $ ▫︎ Found: "map (first $ T.unpack . printOutputable) $ res" ▫︎ Perhaps: "map (first $ T.unpack . printOutputable) res"
|
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|