Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bun #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make bun #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f9337f
Allow to overwrite bun
hasufell Jan 5, 2025
83ad5c7
Add make test
hasufell Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/test-ghcup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ jobs:
runs-on: ubuntu-20.04
container:
image: debian:12
env:
DEBIAN_FRONTEND: noninteractive
TZ: Asia/Singapore
steps:
- run: |
apt-get update
Expand All @@ -87,7 +90,6 @@ jobs:
- run: which cabal
- run: cabal --version


vanilla-channel:
strategy:
matrix:
Expand Down Expand Up @@ -163,3 +165,21 @@ jobs:
run: |
cat $(stack path --stack-root)/hooks/ghc-install.sh
shell: bash

make:
runs-on: ubuntu-latest
container:
image: rockylinux:9
steps:
- run: |
dnf install -y git nodejs make
- uses: actions/checkout@v4
- run: |
set -eux
pushd ghcup
npx bun install
BUN="npx bun" make
popd
git config --global --add safe.directory $PWD
git status
git diff --exit-code
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I get a different index.js here although the source files have not changed.

Locally, I can't reproduce, so something from the environment must be leaking into the output.

5 changes: 4 additions & 1 deletion ghcup/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
.PHONY: dist/index.js

BUN ?= bun

dist/index.js:
bun build --target=node --minify --outfile=$@ src/index.ts
$(BUN) build --target=node --minify --outfile=$@ src/index.ts
Loading