Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option #11

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Add config option #11

merged 1 commit into from
Jan 4, 2025

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Jan 2, 2025

Fixes #10

I was unable to make it work with an object. core.getInput expects a string.

Comment on lines +103 to +113
config: |
# see https://github.com/haskell/ghcup-hs/blob/master/data/config.yaml
# for full documentation
url-source:
- StackSetupURL
verbose: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here... I'd like to be able to have this as an unknown object that we stringify. But core.getInput will fail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not possible reading actions/toolkit#184

@andreabedini
Copy link
Collaborator

I was unable to make it work with an object. core.getInput expects a string.

I think it's standard to use text snippets for configuration.

@andreabedini
Copy link
Collaborator

andreabedini commented Jan 3, 2025

Does this deprecate release-channels?
edit: it does

Copy link
Collaborator

@andreabedini andreabedini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the rebase. Please check I didn't screw it all up :)

@hasufell hasufell merged commit b8ca95b into main Jan 4, 2025
12 checks passed
@hasufell hasufell deleted the config branch January 4, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to specify the entire config
2 participants