Add replaceFile #200
Open
Add replaceFile #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlonast
force-pushed
the
master
branch
4 times, most recently
from
d74c63b to
9c9dc0e
Compare
Bodigrim
reviewed
May 18, 2025
| @@ -709,6 +710,30 @@ renamePath opath npath = | |||
| (`ioeAddLocation` "renamePath") `modifyIOError` do | |||
| renamePathInternal opath npath | |||
|
|
|||
| -- | 'replaceFile' replaces one file with another file. The replacement file | |||
There was a problem hiding this comment.
It would be nice to elaborate explicitly how replaceFile is different from renameFile.
| @@ -52,6 +52,7 @@ module System.Directory.OsPath | |||
| , copyFile | |||
| , copyFileWithMetadata | |||
| , getFileSize | |||
| , replaceFile | |||
There was a problem hiding this comment.
I think the convention is to provide the same set of functions both from System.Directory and from System.Directory.OsPath.
zlonast
force-pushed
the
master
branch
2 times, most recently
from
22cf56c to
cb53340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haskell/cabal#10938
haskell/win32#240