Add --with-repl flag to modify program the "repl" starts with #10996
+206
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactoring modifies the logic to start the multi-repl to use runGHCWithResponseFile rather than directly constructing a command line. Towards #10881
mpickering
changed the title
> hie-bios debug src/HIE/Bios.hs
Root directory: /home/hugin/Documents/haskell/hie-bios
Component directory: /home/hugin/Documents/haskell/hie-bios
GHC options: @/tmp/ghci84462-0.rsp
GHC library directory: CradleSuccess "/home/hugin/.ghcup/ghc/9.6.7/lib/ghc-9.6.7/lib"
GHC version: CradleSuccess "9.6.7"
Config Location: No explicit config found
Cradle: Cradle{ cradleRootDir = "/home/hugin/Documents/haskell/hie-bios", cradleOptsProg = CradleAction: Cabal}
Dependencies: hie-bios.cabal cabal.project cabal.project.localThe branch passes the test-suite with the |
mpickering
force-pushed
the
wip/for-repl
branch
9 times, most recently
from
e347e40 to
c037a88
Compare
Programs like doctest and hie-bios want to use `cabal-install` in order to discover the correct options to start a GHC session. Previously they used the `--with-compiler` option, but this led to complications since the wrapper was called for compiling all dependencies and so on, the shim had to be more complicated and forward arguments onto the user's version of GHC. The `--with-repl` command allows you to pass a program which is used instead of GHC at the final invocation of the repl. Therefore the wrappers don't have to deal with being a complete shim but can concentrate on intercepting the arguments at the end. This commit removes the special hack to not use response files with --interactive mode. Tools are expected to deal with them appropiately, which is much easier now only one invocation is passed to the wrapper. Fixes #9115
geekosaur
reviewed
Jun 23, 2025
| @@ -751,10 +751,10 @@ runReplOrWriteFlags ghcProg lbi rflags ghcOpts pkg_name target = | |||
| verbosity = fromFlag $ setupVerbosity common | |||
| tempFileOptions = commonSetupTempFileOptions common | |||
| in case replOptionsFlagOutput (replReplOptions rflags) of | |||
| NoFlag -> | |||
| runGHCWithResponseFile | |||
There was a problem hiding this comment.
OOC what breaks (or has the potential to break) if we don't use a response file?
| Configuring library for cabal-with-repl-0.1.0.0... | ||
| Preprocessing library for cabal-with-repl-0.1.0.0... | ||
| Error: [Cabal-7125] | ||
| repl failed for cabal-with-repl-0.1.0.0-inplace. |
There was a problem hiding this comment.
I feel like this should provide more information about the failure somewhere.
| ``` | ||
|
|
||
| This change also removes the special handling for response files with `--interactive` | ||
| mode, as tools are now expected to handle response files appropriately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programs like doctest and hie-bios want to use
cabal-installin orderto discover the correct options to start a GHC session. Previously they
used the
--with-compileroption, but this led to complications sincethe wrapper was called for compiling all dependencies and so on, the
shim had to be more complicated and forward arguments onto the user's
version of GHC.
The
--with-replcommand allows you to pass a program which is usedinstead of GHC at the final invocation of the repl. Therefore the
wrappers don't have to deal with being a complete shim but can
concentrate on intercepting the arguments at the end.
This commit removes the special hack to not use response files with
--interactive mode. Tools are expected to deal with them appropiately,
which is much easier now only one invocation is passed to the wrapper.
Fixes #9115
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.