Skip to content

Hi Haddock: don't try to copy artifacts that don't exist #10992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sheaf
Copy link
Collaborator

@sheaf sheaf commented Jun 17, 2025

This fixes a bug in which, if we run cabal haddock without having run cabal build first, then we could try to copy over artifacts that don't exist, which would cause a build failure. Simply not attempting to copy non-existing artifacts fixes the issue.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@sheaf sheaf marked this pull request as draft June 17, 2025 10:25
@ulysses4ever
Copy link
Collaborator

This fixes a bug...

A general guideline, which is also included in our CONTRIBUTING.md, is to have a ticket before a PR. It'd be great if you could find a corresponding issue (if one exists) and link it. Otherwise, opening one with a reproducer is also a good option.

@sheaf sheaf force-pushed the wip/haddockCopyArtifacts branch from 0d19c31 to 929a52f Compare June 18, 2025 09:22
@sheaf
Copy link
Collaborator Author

sheaf commented Jun 18, 2025

This fixes a bug...

A general guideline, which is also included in our CONTRIBUTING.md, is to have a ticket before a PR. It'd be great if you could find a corresponding issue (if one exists) and link it. Otherwise, opening one with a reproducer is also a good option.

I have opened #11001 to track the issue. I added a test and a changelog entry as well.

@sheaf sheaf added the merge me Tell Mergify Bot to merge label Jun 18, 2025
@sheaf sheaf marked this pull request as ready for review June 18, 2025 09:23
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Jun 18, 2025
Copy link
Contributor

mergify bot commented Jun 20, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants