Skip to content

Docs: fix the detailed-0.9 example #10985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chreekat
Copy link
Collaborator

Closes #5124 (in spirit)

Template B: This PR does not modify behaviour or interface

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? [NO] If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm fine with any fix really. I am not sure about comments of this complexity in a little example like this one: the comment now takes a better part of the example... So, I personally would probably just drop the bound. But I understand that different people may disagree on these matters. So, I'm approving as is. Thanks again!

@chreekat
Copy link
Collaborator Author

Tbh I'd just leave off the comment too, but I figured this was the best way to get it merged quickly 😁

@chreekat chreekat added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jun 12, 2025
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Jun 12, 2025
Copy link
Contributor

mergify bot commented Jun 14, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added the waiting too long automatically set by Mergify to trigger a warning label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge newcomer: 1-one-line-change ready and waiting Mergify is waiting out the cooldown period waiting too long automatically set by Mergify to trigger a warning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documented example of detailed-0.9 test-suite has runtime error
3 participants