Skip to content

ci(mergify): upgrade configuration to current format #10978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 7, 2025

Hey there! 👋

We've noticed that your Mergify configuration is using some deprecated fields.

No worries—we've got your back! This automated PR updates your config to align with the newest standards, ensuring everything keeps running smoothly.

Do not procrastinate! You must upgrade your configuration before 2025-06-30, otherwise your configuration will stop working.

What's Changed?

  • The implicit priority for the queue rules, that was based on their order, is going to be removed in favor of using priority_rules.
    This transformation aim to create priority rules, based on your existing queue rules, in order to keep the same priorities. If this priority change is not needed for you, you should not close this pull request until the deadline, otherwise it will be re-created again. (deadline: 2025-06-30)

Why This Matters

Keeping your configuration up-to-date means you'll benefit from the latest features and improvements Mergify has to offer. Plus, it helps prevent any unexpected hiccups down the road.

Got Questions? We've Got Answers! 🙌

Is this update safe to merge?

Absolutely! We've made sure the changes are compatible with your current setup. Your workflows should continue to work just as before—if not better!

Do I need to do anything special after merging?

Nope! Just merge this PR, and you're all set. If you have any custom configurations, it's a good idea to give them a quick look to ensure everything's in order.

What if I run into issues or have concerns?

We're here to help! Feel free to reach out to our support team anytime.

Thanks for being awesome and keeping your configuration up-to-date! If you have any thoughts or need a hand, don't hesitate to let us know.

Happy merging! 🎉

@geekosaur
Copy link
Collaborator

I knew it.

@geekosaur
Copy link
Collaborator

To: [email protected]
Subject: your upgrade notifier really doesn't like our configuration

I'm a member of the Cabal support team. Your bot keeps complaining about our config, but ignoring most of it when "fixing" it. We just received a third "here, I'vve fixed your queue rules" PR that for the third time ignored one of our rules and broke the other. Is there a way to make it happy while keeping our configuration?

Configuration: https://github.com/haskell/cabal/blob/master/.github/mergify.yml
Broken "fix": https://github.com/haskell/cabal/pull/10978/files

The "fix" ignores the squash-merge queue and continually raises the priority of the default queue over the priority of the direct-to-release-branch rule, which is deliberately higher than the default.

@geekosaur geekosaur marked this pull request as draft June 7, 2025 19:55
@ulysses4ever
Copy link
Collaborator

@geekosaur did you send the above message somewhere or is it a draft for comments?

@geekosaur
Copy link
Collaborator

I sent it, we had a few rounds, the conclusion was that we should just let it sit and they're submitting an internal ticket (but I expect that won't go anywhere since the cutoff will pass first).

@geekosaur
Copy link
Collaborator

From: Guillaume at Mergify

Hello, thanks for the report.
The automatic configuration upgrade is mostly a way to warn you about upcoming deprecations, if you don't care about the changes or already fixed your config for the upcoming deprecation then you can just ignore the pull request.

I'll create a ticket on our side to try to fix this issue.
From: geekosaur

https://github.com/haskell/cabal/pull/10921#event-17466617338 made it sound like not….
From: Guillaume at Mergify

The configuration upgrade system is trying to be as generic as possible, that's why some edge case might not be properly handled. As long as your current configuration fits your needs after the deprecation, you can ignore the pull request. It will be automatically closed once the deprecated parts' support has been fully removed, which is near the 30th of June for this case.
I have created a ticket on our side to try to improve the upgrade system.

@ulysses4ever
Copy link
Collaborator

Great, thank you!

Let it sit was my proposal as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants