Deserialize all TypeRep arrow representations #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bgamari You asked for it; you got it. |
|
Thanks! |
Previously, `TypeRep (a -> b)` could only be deserialized if `a` and `b` both had kind `*`. Change that to allow any kinds of the form `TYPE rep`. Fixes haskell#140
treeowl
force-pushed
the
typerep-arrows
branch
from
794ede2 to
d9575cd
Compare
|
Travis failure is unrelated to the changes in this PR and was fixed in #147, a rebase should make the check go green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
TypeRep (a -> b)could only be deserialized ifaandbboth had kind*. Change that to allow any kindsof the form
TYPE rep.Fixes #140