Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add runGetIncremental‘ #125

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add runGetIncremental‘ #125

wants to merge 3 commits into from

Conversation

winterland1989
Copy link

Turned out it's easy to fix the slow runGetIncremental problem: just provide an initial chunk, so that a small getter will return Done quickly. The noMeansNo and extra Decoder still eat some time, but now the overhead is much smaller (100ns -> 15ns on my machine).

@winterland1989 winterland1989 mentioned this pull request Sep 21, 2016
Open
@winterland1989
Copy link
Author

@kolmodin Can you show some light on the build error? i can't find a reason why it failed to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@winterland1989