Skip to content

Switch to GTK3 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 29, 2025
Merged

Switch to GTK3 #137

merged 15 commits into from
May 29, 2025

Conversation

TeofilC
Copy link
Collaborator

@TeofilC TeofilC commented Mar 25, 2025

We upgrade from the deprecated GTK2 to the still supported GTK3.

Most of the changes we had to make were described in the migration guide:
https://docs.gtk.org/gtk3/migrating-2to3.html#changes-that-need-to-be-done-at-the-time-of-the-switch

Many of the functions we depended on for low-level rendering were removed, so I've substituted mostly equivalent ones.

The way events are subscribed to has slightly changed and that has lead to a bunch of changes.

With the new version of GTK3, windows CI works again. Resolves #135, #97

We've also updated the Cabal file to be made aware of stuff included through TH.

@TeofilC TeofilC changed the title Wip/gtk3 Switch to GTK3 Mar 25, 2025
@TeofilC
Copy link
Collaborator Author

TeofilC commented Mar 25, 2025

This compiles but is horribly broken.

For future reference: https://docs.gtk.org/gtk3/migrating-2to3.html#changes-that-need-to-be-done-at-the-time-of-the-switch

@TeofilC
Copy link
Collaborator Author

TeofilC commented Apr 13, 2025

It looks like the segfaults are now fixed!

@TeofilC
Copy link
Collaborator Author

TeofilC commented Apr 14, 2025

Windows CI is now working. Nice!

@arrowd
Copy link

arrowd commented May 28, 2025

It'd be great to have this merged in.

@TeofilC
Copy link
Collaborator Author

TeofilC commented May 28, 2025

@arrowd (or anyone else) it would be helpful to have some people test this branch and see if they can spot some issues. If I have some time at ZuriHac, I might finish this off. Hopefully it should just need tidying up. The styling on some things is a bit weird but it should be OK.

@arrowd
Copy link

arrowd commented May 29, 2025

I managed to compile this on FreeBSD, GHC 9.8.4, Cabal 3.14 just fine. Turns out ThreadScope has a number of built-in sample that can be loaded by running it with --test chX with X ranging from 1 to 8. I played with graphs and buttons with the testing data loaded and everything seems fine to me. Hope that helps.

@TeofilC
Copy link
Collaborator Author

TeofilC commented May 29, 2025

I think I'll just merge this as is and create an issue for the remaining styling work.

@TeofilC TeofilC marked this pull request as ready for review May 29, 2025 09:57
@TeofilC TeofilC merged commit e8996fc into master May 29, 2025
8 checks passed
@TeofilC TeofilC deleted the wip/gtk3 branch May 29, 2025 10:23
@TeofilC TeofilC mentioned this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CI jobs broken
2 participants