-
Notifications
You must be signed in to change notification settings - Fork 36
Switch to GTK3 #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to GTK3 #137
Conversation
This compiles but is horribly broken. For future reference: https://docs.gtk.org/gtk3/migrating-2to3.html#changes-that-need-to-be-done-at-the-time-of-the-switch |
It looks like the segfaults are now fixed! |
Windows CI is now working. Nice! |
It'd be great to have this merged in. |
@arrowd (or anyone else) it would be helpful to have some people test this branch and see if they can spot some issues. If I have some time at ZuriHac, I might finish this off. Hopefully it should just need tidying up. The styling on some things is a bit weird but it should be OK. |
I managed to compile this on FreeBSD, GHC 9.8.4, Cabal 3.14 just fine. Turns out ThreadScope has a number of built-in sample that can be loaded by running it with |
I think I'll just merge this as is and create an issue for the remaining styling work. |
We upgrade from the deprecated GTK2 to the still supported GTK3.
Most of the changes we had to make were described in the migration guide:
https://docs.gtk.org/gtk3/migrating-2to3.html#changes-that-need-to-be-done-at-the-time-of-the-switch
Many of the functions we depended on for low-level rendering were removed, so I've substituted mostly equivalent ones.
The way events are subscribed to has slightly changed and that has lead to a bunch of changes.
With the new version of GTK3, windows CI works again. Resolves #135, #97
We've also updated the Cabal file to be made aware of stuff included through TH.