Stop using gtk-mac-integration and fix broken CI #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtk2hs/gtk-mac-integration has been unmaintained for nearly 3 years now and it makes it harder to build ThreadScope on macOS. We've been using it only to display the logo in the Dock so the effect of this removal is minimal. We can add this feature back when porting ThreadScope to gi-gtk.
gtk needs +have-quartz-gtk constraint to build on macOS. Also some gtk2hs packages need gcc-9 to build. See gtk2hs/gtk2hs#291.
maoe
force-pushed
the
macos-fixes
branch
11 times, most recently
from
5bb3c54 to
a2f53cc
Compare
|
Now CI passes. I'll merge this and cut a release. |
|
Great job! (not that I tested it; just cheerleading :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
The icon in the Dock now looks like this:
The missing logo is certainly not nice but we should be able to add it back when porting ThreadScope to haskell-gi in #100.