Skip to content

Move comparison benchmarks for containers and hashmap behind CPP #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Dec 19, 2021

Note that configuring cpp-options in the cabal.project is currently
unsupported: haskell/cabal#7872

Closes #333.

Note that configuring cpp-options in the cabal.project is currently
unsupported: haskell/cabal#7872

Closes #333.
@sjakobi sjakobi merged commit b941823 into master Dec 21, 2021
@sjakobi sjakobi deleted the 333-bench-cpp branch December 21, 2021 14:55
@treeowl
Copy link
Collaborator

treeowl commented Dec 21, 2021

I'm sorry I didn't speak up earlier, but shouldn't these be runtime flags?

@sjakobi
Copy link
Member Author

sjakobi commented Dec 21, 2021

It would probably have been possible to implement this via some tasty configuration. I don't think it matters much though – I doubt that we'll want to run the containers and hashmap benchmarks very often, and if we do, recompiling the benchmarks is pretty quick.

If this change turns out to cause problems, it should be pretty easy to revert.

@treeowl
Copy link
Collaborator

treeowl commented Dec 21, 2021

Yeah, you're probably right. We almost always just want to see what a commit changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmarks for operations from containers and hashmap should be disabled by default
2 participants