Implement HasForeign instance #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
reviewed
Sep 17, 2018
servant-multipart.cabal
Outdated
| @@ -40,7 +40,8 @@ library | |||
| text >=1.2 && <1.3, | |||
| transformers >=0.3 && <0.6, | |||
| wai >= 3.2 && <3.3, | |||
| wai-extra >=3.0 && <3.1 | |||
| wai-extra >=3.0 && <3.1, | |||
| servant-foreign >= 0.11.2 | |||
There was a problem hiding this comment.
keep the dependencies sorted
afcady
force-pushed
the
multipart-foreign
branch
from
b5e8cfc to
f643378
Compare
alpmestan
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is three patches, to
servant-foreign,servant-multipart, andservant-js.https://github.com/haskell-servant/servant-multipart/compare/master...afcady:multipart-foreign?expand=1
https://github.com/haskell-servant/servant/compare/master...afcady:multipart-foreign?expand=1
https://github.com/haskell-servant/servant-js/compare/master...afcady:multipart-foreign?expand=1
The patch to
servant-foreignadds a Boolean field to theReqtype specifying whether the request body is JSON (as is currently assumed). The patch toservant-multipartimplements a HasForeign instance that sets this field toFalse. The patch toservant-jschanges the output ofvanillaJSwhen the flag is false, so thatJSON.stringify()does not get called on the body and the content-type is not set to JSON.This address #5