Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getURL of instance MonadHttp IO #1051

Merged
merged 10 commits into from
Sep 1, 2022
Merged

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Feb 5, 2022

Now the builtins.fetchurl would be done
Also I unmask the test files
It might close #258 as real implementation
related #1034

@soulomoon
Copy link
Collaborator Author

It seems a lot of name conflict between Effects.hs and hnix store

@soulomoon

This comment was marked as outdated.

@soulomoon

This comment was marked as outdated.

@soulomoon
Copy link
Collaborator Author

soulomoon commented Feb 7, 2022

It's my mistake, the reason is that the addTextToStore and makefixouput use different hash object for hashing a name:

  • text: text:sha256:37268335dd6931045bdcdf92623ff819a64244b53d0e746d438797349d4da578:/nix/store:test
  • makefixouput: fixed:out:sha256:37268335dd6931045bdcdf92623ff819a64244b53d0e746d438797349d4da578: -> b2ddea1e93007908327ef4403126f8e9caa57c4c3d19ea11e382a5d18e9ede62 -> output:out:sha256:b2ddea1e93007908327ef4403126f8e9caa57c4c3d19ea11e382a5d18e9ede62:/nix/store:test

where 37268335dd6931045bdcdf92623ff819a64244b53d0e746d438797349d4da578 is hash of the content.
Here is the problem, how do I add the text along with fixed output through hnix store

src/Nix/Effects.hs Outdated Show resolved Hide resolved
@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Feb 7, 2022

You can open hnix-store reports during work.

It is much more malleable, we can shape API there to fit with hnix.

Also would thank if details as in #1051 (comment) would end-up noted in the source code.

@soulomoon

This comment was marked as outdated.

@soulomoon
Copy link
Collaborator Author

soulomoon commented Feb 7, 2022

How nix implement fetchurl break down into(source) :

@soulomoon
Copy link
Collaborator Author

hnix-store api for addToStore does seems a bit off comparing to nix, we should shape API as in nix.

@soulomoon

This comment was marked as resolved.

@soulomoon
Copy link
Collaborator Author

soulomoon commented Feb 10, 2022

The work should continue after haskell-nix/hnix-store#177 is merged or haskell-nix/hnix-store#176 is solved.

@soulomoon soulomoon marked this pull request as ready for review August 22, 2022 20:05
@soulomoon soulomoon mentioned this pull request Aug 22, 2022
@soulomoon soulomoon merged commit 2932f30 into haskell-nix:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants