-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ex12 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next, I have to find a way to get stdout/stderr as a merged ByteString
…r printed by the user's answer
…r printed by the user's answer
…r printed by the user's answer
Use appropriate type synonym for the argument of executeCommand Fix: Make the command name relative before using it as the part of a temporary directory name Add a TODO about duplicated code Add ExitCode to the argument of Judge type Fix compile errors in the test
Necessary to implement Ex12
またテスト落ちた... 今度は課題12の判定処理(あるいはデータ生成?)のバグだろうか。
|
今日の勉強会で調べたところ、どうもQuickCheckで連続してコマンドを実行した際、たまにコマンドの出力が空文字列として取得されてしまう、という現象が起きているらしい。 |
再現コードを作るのが非常に面倒でしたがなんとか書いた。 |
どうも解決するのが難しそうなので、一旦後回しにしてマージします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題12は、初めて標準入力を扱うアプリケーションのverifyを行う必要があったので、Excercise.Coreモジュールを中心に、多くの箇所を書き換えました。
そのため、一時的にex6ブランチから分岐していました。
テストが通り次第マージします。