Re-export ReleaseKey and ResourceCleanupException #5
Conversation
src/Effectful/Resource.hs
Outdated
|
|
||
| -- | A variant of 'R.unprotect' adjusted to work in the 'Eff' monad. | ||
| -- | ||
| -- /Note:/ the @release@ action returned will run a clone of the environment it |
There was a problem hiding this comment.
Will it? I don't know what unprotect does, but I don't see cloneEnv below (unlike in allocateEff).
Also, is having es and es' correct here? Does it make sense to be able to run the returned action in a completely different stack?
There was a problem hiding this comment.
Will it? I don't know what
unprotectdoes, but I don't seecloneEnvbelow (unlike inallocateEff).
You're right, it does not run in a cloned environment - at least not necessarily. I wrote the note with alloacteEff in mind and there the release action is run in a cloned environment. I updated the note to be a bit clearer on that.
Also, is having
esandes'correct here? Does it make sense to be able to run the returned action in a completely different stack?
Yes, I think it makes sense. Consider the use case mentioned in the documentation of the unprotect:
Unprotect resource from cleanup actions; this allows you to send resource into another resourcet process and reregister it there.
We don't now what the effect row of that other resourcet process looks like and it might (and probably will) be different from the one we are in when calling unprotectEff.
I moved the CI part to #6. |
Also provide Eff versions of release and unprotect.
Fixes #2
I also updated the CI setup and added bindings for
releaseandunprotect.@arybczak Maybe we can cut a new release at this point?