Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H-1553, H-3395, H-3397: Entity editor UX improvements and bug fixes #5314

Merged
merged 3 commits into from
Oct 4, 2024
Merged

H-1553, H-3395, H-3397: Entity editor UX improvements and bug fixes #5314

merged 3 commits into from
Oct 4, 2024

Conversation

CiaranMn
Copy link
Member

@CiaranMn CiaranMn commented Oct 4, 2024

🌟 What is the purpose of this PR?

The following improvements to the entity editor:

  • H-3395: show entity URL property values as clickable links in readonly mode
  • H-1553: allow viewing entity property text in popup in readonly mode
  • H-3397: better handling of loading entities into slideover from entities page (it was previously waiting for the 'entities with links data' to load in, which could take a while – now it loads the data without links, and makes a separate request for the specific's entity's links, which is fast. This seemed like better UX than a loading skeleton until the links loaded in)

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) type/eng > frontend Owned by the @frontend team area/apps labels Oct 4, 2024
@CiaranMn CiaranMn added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit f0dbe87 Oct 4, 2024
34 of 35 checks passed
@CiaranMn CiaranMn deleted the cm/entity-editor-ux-and-bugs branch October 4, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilkinsons vilkinsons vilkinsons approved these changes

Assignees
No one assigned
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps type/eng > frontend Owned by the @frontend team
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CiaranMn @vilkinsons