-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin register with artifact stubs VAULT-32686 #29113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Dec 5, 2024
CI Results: |
Build Results: |
…hub.com:hashicorp/vault into VAULT-32686-plugin-register-with-artifact-stubs
thyton
force-pushed
the
VAULT-32686-plugin-register-with-artifact-stubs
branch
from
December 18, 2024 23:29
1b118d9
to
0d1b748
Compare
thyton
added
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
backport/1.18.x
backport/ent/1.17.x+ent
Changes are backported to 1.17.x+ent
labels
Dec 19, 2024
thyton
force-pushed
the
VAULT-32686-plugin-register-with-artifact-stubs
branch
from
December 29, 2024 01:56
b11e957
to
95a23de
Compare
…hub.com:hashicorp/vault into VAULT-32686-plugin-register-with-artifact-stubs
fairclothjm
approved these changes
Jan 9, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
backport/ent/1.17.x+ent
Changes are backported to 1.17.x+ent
backport/1.18.x
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
pr/no-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
plugin register
to omit sha256 parameter on registration with artifact on Enterprise serversEnterprise
field to plugin runnerRelated ENT PR: https://github.com/hashicorp/vault-enterprise/pull/7107 (which needs to be rebased off
main
after these CE changes are brought into ENTmain
)Ticket: VAULT-32686
RFC: https://go.hashi.co/rfc/vlt-337
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.