Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin register with artifact stubs VAULT-32686 #29113

Merged
merged 32 commits into from
Jan 9, 2025

Conversation

thyton
Copy link
Contributor

@thyton thyton commented Dec 5, 2024

Description

What does this PR do?

  • allows plugin register to omit sha256 parameter on registration with artifact on Enterprise servers
  • adds CE stub for unpacking artifact on plugin register with artifact
  • adds Enterprise field to plugin runner
  • adds CE stub for sanitizing Enterprise plugin directories during plugin catalog setup

Related ENT PR: https://github.com/hashicorp/vault-enterprise/pull/7107 (which needs to be rebased off main after these CE changes are brought into ENT main)
Ticket: VAULT-32686
RFC: https://go.hashi.co/rfc/vlt-337

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@thyton thyton requested a review from a team as a code owner December 5, 2024 23:19
@thyton thyton requested a review from tcrayford December 5, 2024 23:19
@thyton thyton marked this pull request as draft December 5, 2024 23:19
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 5, 2024
@thyton thyton added this to the 1.19.0-rc milestone Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Dec 5, 2024

Build Results:
All builds succeeded! ✅

@thyton thyton force-pushed the VAULT-32686-plugin-register-with-artifact-stubs branch from 1b118d9 to 0d1b748 Compare December 18, 2024 23:29
@thyton thyton marked this pull request as ready for review December 19, 2024 00:14
@thyton thyton added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Dec 19, 2024
@thyton thyton requested a review from a team December 19, 2024 17:28
@thyton thyton force-pushed the VAULT-32686-plugin-register-with-artifact-stubs branch from b11e957 to 95a23de Compare December 29, 2024 01:56
@thyton thyton merged commit 4f14f7b into main Jan 9, 2025
90 of 92 checks passed
@thyton thyton deleted the VAULT-32686-plugin-register-with-artifact-stubs branch January 9, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants