Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces go-autorest MS graph client with msgraph-sdk-go #121

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

austingebauer
Copy link
Contributor

@austingebauer austingebauer commented Jul 19, 2023

Overview

This PR replaces the deprecated go-autorest module with msgraph-sdk-go. Additionally, it migrates the azure-sdk-for-go to the new package structure (see related issue).

There are no known API changes or compatibility breaks in this PR.

Testing

All tests in the repository are passing. Additionally, I manually tested the secrets engine functionality using our Terraform bootstrap which pulls an IMDS token off of a VM.

I've additionally added an acceptance test that actually uses Azure resources to login in.

Related Issues/Pull Requests

Contributor Checklist

  • Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
  • Backwards compatible

@austingebauer austingebauer requested a review from a team July 19, 2023 23:36
azure.go Show resolved Hide resolved
Copy link
Contributor

@raymonstah raymonstah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! question about the error handling: I noticed that a lot of the if err checks return the error directly. Do we feel that the error returned provides enough context? If not, we can consider wrapping them.

azure.go Outdated Show resolved Hide resolved
@austingebauer
Copy link
Contributor Author

austingebauer commented Jul 21, 2023

Good point @raymonstah. Added more error context and moved some context around in 3bcea36.

Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for working through this!

@austingebauer austingebauer merged commit 2fc43e1 into main Jul 24, 2023
@austingebauer austingebauer deleted the replace-go-autorest branch July 24, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants