Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NetRC support to the provider installer #35843

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaklilu
Copy link

@aaklilu aaklilu commented Oct 11, 2024

An interim solution to lack of credential while downloading provider archives.

Fixes #29349

Target Release

1.10.x

Draft CHANGELOG entry

ENHANCEMENTS

  • Provider installation now support NetRC and utilises the credentials configured in .netrc file. Similar to module downloads.

@crw
Copy link
Collaborator

crw commented Oct 11, 2024

Thanks for this submission!

@crw
Copy link
Collaborator

crw commented Oct 15, 2024

Hi @aaklilu, we discussed this in triage today. Generally speaking there is agreement that this is probably the correct approach. The main blocker to doing a full review is maintainer availability. My best guess is that we'll check back in on this PR mid-November to consider a review. I just wanted to set expectations up-front as to timelines. Thanks again for this submission.

@aaklilu
Copy link
Author

aaklilu commented Oct 15, 2024

Hi @aaklilu, we discussed this in triage today. Generally speaking there is agreement that this is probably the correct approach. The main blocker to doing a full review is maintainer availability. My best guess is that we'll check back in on this PR mid-November to consider a review. I just wanted to set expectations up-front as to timelines. Thanks again for this submission.

Thank you @crw for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants