Idempotent Init: Only mount if not mounted yet #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
miguelhrocha
approved these changes
Apr 3, 2024
nikolasrieble
commented
Apr 4, 2024
| @@ -89,8 +89,16 @@ else | |||
| fi | |||
| echo "[Terraform Enterprise] Creating mounted disk directory at '${disk_path}'" | tee -a $log_pathname | |||
| mkdir --parents ${disk_path} | |||
| echo "[Terraform Enterprise] Mounting disk '$device' to directory at '${disk_path}'" | tee -a $log_pathname | |||
| mount --options discard,defaults $device ${disk_path} | |||
| if findmnt -rno SOURCE,TARGET $device | grep -q $disk_path; then | |||
There was a problem hiding this comment.
Suggested change
| if findmnt -rno SOURCE,TARGET $device | grep -q $disk_path; then | |
| if findmnt -rno SOURCE,TARGET $device | grep -q "$disk_path"; then |
There was a problem hiding this comment.
Could be an issue otherwise, if the disk_path contained spaces.
TODO: Test again.
There was a problem hiding this comment.
Fun.
During testing on Ubuntu 22.04.4 LTS, I mounted /path/to/your mount point onto /dev/vda1.
device="/dev/vda1"
disk_path="/path/to/your mount point"
mount "$device" "$disk_path"
Which works, as we see:
findmnt -rno SOURCE,TARGET "$device"
...
/dev/vda1 /path/to/your\x20mount\x20point
In the output of findmnt, whitespaces are replaced with \x20.
In this case, we will find no match with | grep -q "$disk_path".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
While I tested the migration guide for Podman, and wanted to rollback, the startup script would not run through.
During the Rollback steps, the startup script fails with
mount: /opt/hashicorp/data: /dev/sdb already mounted on /opt/hashicorp/data.The solution to this is to unmount first with
umount /dev/sdband then rerun the script.To prevent future engineers from this manual step, I suggest to adapt the initialization script to make it idempotent with respect to the mount.
To make the script fully idempotent there might be more changes needed, but lets tackle this one step at a time.
How has this been tested?
I tested this adaption when I rolled back the podman installation to replicated.
This PR makes me feel
🔁