Skip to content

Commit

Permalink
PR review: Fix changelog. Cleanup commented out code.
Browse files Browse the repository at this point in the history
  • Loading branch information
victorr committed Jan 28, 2025
1 parent b3ca0c9 commit 1c6b743
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
7 changes: 4 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
## Unreleased

FEATURES:

* Update `vault_pki_secret_backend_root_cert` and `vault_pki_secret_backend_root_sign_intermediate` to support the new fields for the name constraints extension. Requires Vault 1.19+ ([#2396](https://github.com/hashicorp/terraform-provider-vault/pull/2396)).

BUGS:

* Do not panic on Vault PKI roles without the cn_validations field: ([#2398](https://github.com/hashicorp/terraform-provider-vault/pull/2398))


## 4.6.0 (Jan 15, 2025)

FEATURES:
Expand All @@ -15,8 +18,6 @@ FEATURES:
* Update `vault_pki_secret_backend_role` to support the `cn_validations` role field ([#1820](https://github.com/hashicorp/terraform-provider-vault/pull/1820)).
* Add new resource `vault_pki_secret_backend_acme_eab` to manage PKI ACME external account binding tokens. Requires Vault 1.14+. ([#2367](https://github.com/hashicorp/terraform-provider-vault/pull/2367))
* Add new data source and resource `vault_pki_secret_backend_config_cmpv2`. Requires Vault 1.18+. *Available only for Vault Enterprise* ([#2330](https://github.com/hashicorp/terraform-provider-vault/pull/2330))
* Update `vault_pki_secret_backend_root_cert` and `vault_pki_secret_backend_root_sign_intermediate` to support the new fields for the name constraints extension. Requires Vault 1.19+ ([#2396](https://github.com/hashicorp/terraform-provider-vault/pull/2396)).

IMPROVEMENTS:

* Support the event `subscribe` policy capability for `vault_policy_document` data source ([#2293](https://github.com/hashicorp/terraform-provider-vault/pull/2293))
Expand Down
1 change: 0 additions & 1 deletion vault/resource_pki_secret_backend_root_cert_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ func checkCertificateNameConstraints(resourceName string, s *terraform.State) er
if err != nil {
return err
}
//fmt.Printf("certificate https://lapo.it/asn1js/#%s\n", hex.EncodeToString(b.Bytes))

cert, err = x509.ParseCertificate(b.Bytes)
if err != nil {
Expand Down

0 comments on commit 1c6b743

Please sign in to comment.